blaginin commented on issue #15396: URL: https://github.com/apache/datafusion/issues/15396#issuecomment-2818421402
Hey @qstommyshu, I think there are a bit more optimizer tests to transition, would you be interested in switching them? - https://github.com/apache/datafusion/blob/91ad9fda2652f584d786a964ee205829e7a84580/datafusion/optimizer/src/common_subexpr_eliminate.rs#L1059-L1061 - https://github.com/apache/datafusion/blob/91ad9fda2652f584d786a964ee205829e7a84580/datafusion/optimizer/src/eliminate_nested_union.rs#L165-L170 - https://github.com/apache/datafusion/blob/91ad9fda2652f584d786a964ee205829e7a84580/datafusion/optimizer/src/decorrelate_predicate_subquery.rs#L518-L529 I think a good step to catch all the cases would be to delete `assert_optimized_plan_equal`, `assert_optimized_plan_eq`, `assert_optimized_plan_eq_display_indent` and so own and see where it fails -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
