comphead commented on code in PR #15796:
URL: https://github.com/apache/datafusion/pull/15796#discussion_r2053064816
##########
datafusion/sql/src/expr/function.rs:
##########
@@ -408,17 +408,12 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
if let Some(suggested_func_name) =
suggest_valid_function(&name, is_function_window,
self.context_provider)
{
- plan_err!("Invalid function '{name}'.\nDid you mean
'{suggested_func_name}'?")
- .map_err(|e| {
- let span = Span::try_from_sqlparser_span(sql_parser_span);
- let mut diagnostic =
- Diagnostic::new_error(format!("Invalid function
'{name}'"), span);
- diagnostic.add_note(
- format!("Possible function '{}'", suggested_func_name),
- None,
- );
- e.with_diagnostic(diagnostic)
- })
+ let span = Span::try_from_sqlparser_span(sql_parser_span);
+ let mut diagnostic =
+ Diagnostic::new_error(format!("Invalid function '{name}'"),
span);
+ diagnostic
+ .add_note(format!("Possible function '{}'",
suggested_func_name), None);
+ plan_err!("Invalid function '{name}'.\nDid you mean
'{suggested_func_name}'?"; diag=diagnostic)
Review Comment:
that would be not very obvious it is true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
