comphead commented on code in PR #1649:
URL: https://github.com/apache/datafusion-comet/pull/1649#discussion_r2053073784
##########
spark/src/main/scala/org/apache/comet/CometExecIterator.scala:
##########
@@ -92,7 +92,8 @@ class CometExecIterator(
memoryLimitPerTask = getMemoryLimitPerTask(conf),
taskAttemptId = TaskContext.get().taskAttemptId,
debug = COMET_DEBUG_ENABLED.get(),
- explain = COMET_EXPLAIN_NATIVE_ENABLED.get())
+ explain = COMET_EXPLAIN_NATIVE_ENABLED.get(),
+ sparkConfig = SparkEnv.get.conf.getAll.toMap)
Review Comment:
Comments are super valid and everything done in local branch yes, haven't
yet pushed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
