hsiang-c commented on code in PR #1668:
URL: https://github.com/apache/datafusion-comet/pull/1668#discussion_r2053091826
##########
pom.xml:
##########
@@ -47,9 +47,27 @@ under the License.
<java.version>11</java.version>
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
+ <maven-compiler-plugin.version>3.11.0</maven-compiler-plugin.version>
+ <maven-assembly-plugin.version>3.6.0</maven-assembly-plugin.version>
+ <maven-shade-plugin.version>3.5.0</maven-shade-plugin.version>
+ <maven-surefire-plugin.version>3.1.2</maven-surefire-plugin.version>
+ <maven-source-plugin.version>3.3.0</maven-source-plugin.version>
+ <maven-enforcer-plugin.version>3.3.0</maven-enforcer-plugin.version>
+ <maven-failsafe-plugin.version>3.1.0</maven-failsafe-plugin.version>
+ <asm.version>9.5</asm.version>
+
<build-helper-maven-plugin.version>3.4.0</build-helper-maven-plugin.version>
+ <flatten-maven-plugin.version>1.3.0</flatten-maven-plugin.version>
+ <scalastyle-maven-plugin.version>1.0.0</scalastyle-maven-plugin.version>
+
<git-commit-id-maven-plugin.version>4.9.9</git-commit-id-maven-plugin.version>
+ <exec-maven-plugin.version>3.1.0</exec-maven-plugin.version>
+ <protoc-jar-maven-plugin.version>3.11.4</protoc-jar-maven-plugin.version>
+ <scalafix-maven-plugin.version>0.1.7_0.10.4</scalafix-maven-plugin.version>
+ <extra-enforcer-rules.version>1.7.0</extra-enforcer-rules.version>
Review Comment:
ref: https://github.com/apache/spark/blob/v3.5.5/pom.xml#L2906
##########
pom.xml:
##########
@@ -47,9 +47,27 @@ under the License.
<java.version>11</java.version>
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
+ <maven-compiler-plugin.version>3.11.0</maven-compiler-plugin.version>
+ <maven-assembly-plugin.version>3.6.0</maven-assembly-plugin.version>
+ <maven-shade-plugin.version>3.5.0</maven-shade-plugin.version>
+ <maven-surefire-plugin.version>3.1.2</maven-surefire-plugin.version>
+ <maven-source-plugin.version>3.3.0</maven-source-plugin.version>
+ <maven-enforcer-plugin.version>3.3.0</maven-enforcer-plugin.version>
+ <maven-failsafe-plugin.version>3.1.0</maven-failsafe-plugin.version>
+ <asm.version>9.5</asm.version>
+
<build-helper-maven-plugin.version>3.4.0</build-helper-maven-plugin.version>
+ <flatten-maven-plugin.version>1.3.0</flatten-maven-plugin.version>
+ <scalastyle-maven-plugin.version>1.0.0</scalastyle-maven-plugin.version>
+
<git-commit-id-maven-plugin.version>4.9.9</git-commit-id-maven-plugin.version>
+ <exec-maven-plugin.version>3.1.0</exec-maven-plugin.version>
+ <protoc-jar-maven-plugin.version>3.11.4</protoc-jar-maven-plugin.version>
+ <scalafix-maven-plugin.version>0.1.7_0.10.4</scalafix-maven-plugin.version>
+ <extra-enforcer-rules.version>1.7.0</extra-enforcer-rules.version>
+ <scalafmt.version>3.6.1</scalafmt.version>
+ <apache-rat-plugin.version>0.16</apache-rat-plugin.version>
<scala.version>2.12.18</scala.version>
<scala.binary.version>2.12</scala.binary.version>
- <scala.plugin.version>4.7.2</scala.plugin.version>
+ <scala.plugin.version>4.8.0</scala.plugin.version>
Review Comment:
ref: https://github.com/apache/spark/blob/v3.5.5/pom.xml#L180
##########
pom.xml:
##########
@@ -396,7 +414,7 @@ under the License.
<dependency>
<groupId>org.scalatestplus</groupId>
<artifactId>junit-4-13_${scala.binary.version}</artifactId>
- <version>3.2.14.0</version>
+ <version>3.2.16.0</version>
Review Comment:
Apache Spark v3.5.3 doesn't use this artifact, but can find similar
artifacts from the same group:
https://github.com/apache/spark/blob/v3.5.5/pom.xml#L1150-L1165
Confirm that this artifact is available on Maven central:
https://mvnrepository.com/artifact/org.scalatestplus/junit-4-13_2.12/3.2.16.0
##########
pom.xml:
##########
@@ -47,9 +47,27 @@ under the License.
<java.version>11</java.version>
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
+ <maven-compiler-plugin.version>3.11.0</maven-compiler-plugin.version>
+ <maven-assembly-plugin.version>3.6.0</maven-assembly-plugin.version>
+ <maven-shade-plugin.version>3.5.0</maven-shade-plugin.version>
+ <maven-surefire-plugin.version>3.1.2</maven-surefire-plugin.version>
+ <maven-source-plugin.version>3.3.0</maven-source-plugin.version>
+ <maven-enforcer-plugin.version>3.3.0</maven-enforcer-plugin.version>
+ <maven-failsafe-plugin.version>3.1.0</maven-failsafe-plugin.version>
+ <asm.version>9.5</asm.version>
+
<build-helper-maven-plugin.version>3.4.0</build-helper-maven-plugin.version>
+ <flatten-maven-plugin.version>1.3.0</flatten-maven-plugin.version>
+ <scalastyle-maven-plugin.version>1.0.0</scalastyle-maven-plugin.version>
+
<git-commit-id-maven-plugin.version>4.9.9</git-commit-id-maven-plugin.version>
+ <exec-maven-plugin.version>3.1.0</exec-maven-plugin.version>
+ <protoc-jar-maven-plugin.version>3.11.4</protoc-jar-maven-plugin.version>
Review Comment:
ref: https://github.com/apache/spark/blob/v3.5.5/pom.xml#L128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
