jayzhan211 commented on code in PR #15769: URL: https://github.com/apache/datafusion/pull/15769#discussion_r2053975043
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -5006,7 +5006,7 @@ SELECT column5, avg(column1) FROM d GROUP BY column5; query I?? SELECT column5, column1, avg(column1) OVER (PARTITION BY column5 ORDER BY column1 ROWS BETWEEN 1 PRECEDING AND CURRENT ROW) as window_avg -FROM d WHERE column1 IS NOT NULL; +FROM d WHERE column1 IS NOT NULL ORDER BY column5 DESC; Review Comment: You probably need to rebase. partition by is similar to group by, so you won't get the deterministic result. You need `rowsort` for this kind of query https://github.com/apache/datafusion/blob/449c744c8369ecc3436d39010ceb70b271389c5f/datafusion/sqllogictest/test_files/aggregate.slt#L5008-L5015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
