eliaperantoni commented on PR #15696:
URL: https://github.com/apache/datafusion/pull/15696#issuecomment-2821404985
> The warning detection is integrated during `BinaryExpr` processing, which
should naturally limit it to predicate contexts. Statements like `UPDATE users
SET password = NULL` won't trigger false warnings by default. Could you confirm
this approach is acceptable?
Absolutely, that sounds good. And very thoughtful of you to check that
`UPDATE` is not affected :)
> In usual cases, the left operand is an `Identifier`. The current
implementation combines the identifier's left span with NULL's right span for
precise highlighting. For rare non-identifier cases (e.g., some complex
expressions that I can't immediately come up with one right now), we fall back
to using just the NULL span. This balances precision with robustness.
Nice! 💯
> While I've added tests for basic and multiple `= NULL` cases, could you
suggest any edge cases or additional scenarios that should be validated?
Perhaps accessing fields of structs? eg:
```sql
SELECT get_field({'x': null}, 'x') = null;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
