etseidl commented on code in PR #15816:
URL: https://github.com/apache/datafusion/pull/15816#discussion_r2054873962
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -931,6 +931,7 @@ fn coerce_numeric_type_to_decimal(numeric_type: &DataType)
-> Option<DataType> {
Int32 | UInt32 => Some(Decimal128(10, 0)),
Int64 | UInt64 => Some(Decimal128(20, 0)),
// TODO if we convert the floating-point data to the decimal type, it
maybe overflow.
+ Float16 => Some(Decimal128(6, 3)),
Review Comment:
I noticed this and the `Decimal256` case while fixing `numerical_coercion`.
I haven't found any bugs triggered by this so I'm happy to remove for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
