Garamda commented on PR #13511: URL: https://github.com/apache/datafusion/pull/13511#issuecomment-2823913238
@jayzhan211 Thank you for reviewing! However, I have one concern. Is it okay to merge this PR right away, considering https://github.com/apache/datafusion/pull/13511#pullrequestreview-2658551401 ? > > One big question we might need to answer before merging is if we need a migration strategy for this. Because we now require WITHIN GROUP for these functions, any users who have queries stored outside of DataFusion will experience breakages that they can't work around. If we want to provide a migration path, we may need to support having both forms of calling these functions, as in > > ``` > SELECT approx_percentile_cont(column_name, 0.75, 100) FROM table_name; > SELECT approx_percentile_cont(0.75, 100) WITHIN GROUP (ORDER BY column_name) FROM table_name; > ``` > > for at least 1 release so folks can migrate their queries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
