XiangpengHao commented on code in PR #15827:
URL: https://github.com/apache/datafusion/pull/15827#discussion_r2056278172
##########
datafusion/functions-aggregate/src/min_max.rs:
##########
@@ -1854,9 +1866,31 @@ mod tests {
#[test]
fn test_get_min_max_return_type_coerce_dictionary() -> Result<()> {
let data_type =
- DataType::Dictionary(Box::new(DataType::Utf8),
Box::new(DataType::Int32));
+ DataType::Dictionary(Box::new(DataType::Int32),
Box::new(DataType::Utf8));
Review Comment:
I don't think Dict<Utf8, Int32> is a valid dictionary type, so I swapped the
key and value. Maybe we should do something to only allow
`ArrowDictionaryKeyType` as the key type, but it's not obvious how to enforce
it with the current enum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
