waynexia commented on code in PR #15828:
URL: https://github.com/apache/datafusion/pull/15828#discussion_r2056500052
##########
datafusion/execution/src/memory_pool/mod.rs:
##########
@@ -141,6 +141,24 @@ pub trait MemoryPool: Send + Sync + std::fmt::Debug {
/// Return the total amount of memory reserved
fn reserved(&self) -> usize;
+
+ /// Return the memory limit of the pool
+ ///
+ /// The default implementation of `MemoryPool::memory_limit`
+ /// will return `MemoryLimit::Unknown`.
+ /// If you are using your custom memory pool, but have the requirement to
+ /// know the memory usage limit of the pool, please implement this method
+ /// to return it(`Memory::Finite(limit)`).
+ fn memory_limit(&self) -> MemoryLimit {
+ MemoryLimit::Unknown
+ }
+}
+
+/// Memory limit of `MemoryPool`
+pub enum MemoryLimit {
+ Infinite,
+ Finite(usize),
Review Comment:
Sugg: specify the unit.
```suggestion
/// Bounded memory limit in bytes.
Finite(usize),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
