vadimpiven commented on code in PR #15825:
URL: https://github.com/apache/datafusion/pull/15825#discussion_r2057920398
##########
datafusion/core/tests/execution/logical_plan.rs:
##########
@@ -96,3 +100,37 @@ where
};
element
}
+
+#[test]
+fn inline_scan_projection_test() -> Result<()> {
+ let name = UNNAMED_TABLE;
+ let column = "a";
+
+ let schema = Schema::new(vec![
+ Field::new("a", DataType::Int32, false),
+ Field::new("b", DataType::Int32, false),
+ ]);
+ let projection = vec![schema.index_of(column)?];
+
+ let provider = ViewTable::new(
+ LogicalPlan::EmptyRelation(EmptyRelation {
+ produce_one_row: false,
+ schema: DFSchemaRef::new(DFSchema::try_from(schema)?),
+ }),
+ None,
+ );
+ let source = provider_as_source(Arc::new(provider));
+
+ let plan = LogicalPlanBuilder::scan(name, source,
Some(projection))?.build()?;
+
+ assert_snapshot!(
+ format!("{plan}"),
+ @r"
Review Comment:
Actually, I just thought that the correct test would be
```
assert_eq!(
plan.schema().field_names(),
vec![format!("{name}.{column}")]
);
```
because what matters is that projection is applied, not how
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
