jayzhan211 commented on code in PR #15822:
URL: https://github.com/apache/datafusion/pull/15822#discussion_r2058019883
##########
datafusion/physical-optimizer/src/enforce_sorting/replace_with_order_preserving_variants.rs:
##########
@@ -138,6 +138,21 @@ fn plan_with_order_preserving_variants(
} else if is_coalesce_partitions(&sort_input.plan) && is_spm_better {
let child = &sort_input.children[0].plan;
if let Some(ordering) = child.output_ordering() {
+ let mut fetch = fetch;
+ if let Some(coalesce_fetch) = sort_input.plan.fetch() {
+ if let Some(sort_fetch) = fetch {
+ if coalesce_fetch < sort_fetch {
+ return Err(
+ DataFusionError::Internal(
Review Comment:
nit: `internal_err!`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
