parthchandra commented on code in PR #1679: URL: https://github.com/apache/datafusion-comet/pull/1679#discussion_r2058887934
########## native/core/src/lib.rs: ########## @@ -50,6 +54,10 @@ pub mod execution; mod jvm_bridge; pub mod parquet; +#[cfg(all(not(target_env = "msvc"), feature = "jemalloc"))] Review Comment: Should we have a check to make sure both jemalloc and mimalloc cannot be enabled at the same time? ``` #[cfg(all(feature = "jemalloc", feature = "mimalloc"))] compile_error!("feature \"jemalloc\" and feature \"mimalloc\" cannot be enabled at the same time"); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org