Rachelint commented on PR #15851: URL: https://github.com/apache/datafusion/pull/15851#issuecomment-2831226388
@jayzhan211 Maybe we can improve the testing of sorted cases like that? In `data generation` part, we randomly generate the sort keys both number and type, rather than only `[u8_low]` and `[utf8_low, u8_low]` right now. And in `sql generation` part: - We need to ensure that the specific generated sql must be picked by the right sorted dataset. Like `SELECT xxx from xxx GROUP BY a,b` must be picked by `dataset sorted by a,b`. - We should ensure all ordering situations can be covered. At least `1 full ordering` + `1 partial ordering` + `1 no ordering` . Like `dataset sorted by a,b`, can ensure at least following three cases: ``` SELECT xxx from xxx GROUP BY a,b SELECT xxx from xxx GROUP BY a,c SELECT xxx from xxx GROUP BY b ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
