jayzhan211 commented on code in PR #15859:
URL: https://github.com/apache/datafusion/pull/15859#discussion_r2061085496
##########
datafusion/expr-common/src/interval_arithmetic.rs:
##########
@@ -286,6 +286,11 @@ impl Interval {
}
}
+ /// Create a new `Interval` with the same lower and upper bounds.
+ pub fn try_singleton(value: ScalarValue) -> Self {
Review Comment:
> Another idiomatic possibility would be to implement From<ScalarValue> for
Interval.
Sounds good!
##########
datafusion/expr-common/src/interval_arithmetic.rs:
##########
@@ -286,6 +286,11 @@ impl Interval {
}
}
+ /// Create a new `Interval` with the same lower and upper bounds.
+ pub fn try_singleton(value: ScalarValue) -> Self {
Review Comment:
> Another idiomatic possibility would be to implement From<ScalarValue> for
Interval.
Sounds good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
