comphead commented on code in PR #15847:
URL: https://github.com/apache/datafusion/pull/15847#discussion_r2061501099
##########
datafusion/common/src/dfschema.rs:
##########
@@ -969,12 +969,15 @@ impl Display for DFSchema {
/// widely used in the DataFusion codebase.
pub trait ExprSchema: std::fmt::Debug {
/// Is this column reference nullable?
+ #[deprecated(since = "48.0.0", note = "Use ExprSchemable::to_field")]
fn nullable(&self, col: &Column) -> Result<bool>;
/// What is the datatype of this column?
+ #[deprecated(since = "48.0.0", note = "Use ExprSchemable::to_field")]
Review Comment:
```suggestion
#[deprecated(since = "48.0.0", note = "Use ExprSchemable::data_type")]
```
##########
datafusion/common/src/dfschema.rs:
##########
@@ -969,12 +969,15 @@ impl Display for DFSchema {
/// widely used in the DataFusion codebase.
pub trait ExprSchema: std::fmt::Debug {
/// Is this column reference nullable?
+ #[deprecated(since = "48.0.0", note = "Use ExprSchemable::to_field")]
fn nullable(&self, col: &Column) -> Result<bool>;
/// What is the datatype of this column?
+ #[deprecated(since = "48.0.0", note = "Use ExprSchemable::to_field")]
fn data_type(&self, col: &Column) -> Result<&DataType>;
/// Returns the column's optional metadata.
+ #[deprecated(since = "48.0.0", note = "Use ExprSchemable::to_field")]
Review Comment:
```suggestion
#[deprecated(since = "48.0.0", note = "Use ExprSchemable::metadata")]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
