chenkovsky commented on PR #15867:
URL: https://github.com/apache/datafusion/pull/15867#issuecomment-2835208591

   I tried to do single thread distinct, but no performance gain.
   
   something like:
   
   ```
   impl<T> Accumulator for PrimitiveDistinctCountAccumulator<T> {
     fn update_batch(&mut self, values: &[ArrayRef]) -> 
datafusion_common::Result<()> {
        //  don't dedup
     }
   
     fn merge_batch(&mut self, states: &[ArrayRef]) -> 
datafusion_common::Result<()> {
       // don't dedup
     }
   
    fn evaluate(&mut self) -> datafusion_common::Result<ScalarValue> {
       // do dedup
     }
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to