alamb commented on code in PR #15836:
URL: https://github.com/apache/datafusion/pull/15836#discussion_r2064905078
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -1606,8 +1606,9 @@ impl<S: SimplifyInfo> TreeNodeRewriter for Simplifier<'_,
S> {
}))
}
Some(pattern_str)
- if !pattern_str
- .contains(['%', '_',
escape_char].as_ref()) =>
+ if !like.case_insensitive
+ && !pattern_str
+ .contains(['%', '_',
escape_char].as_ref()) =>
{
// If the pattern does not contain any
wildcards, we can simplify the like expression to an equality expression
// TODO: handle escape characters
Review Comment:
looks like we have completed the TODO as well -- can yoy remove this comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
