alamb commented on code in PR #15544:
URL: https://github.com/apache/datafusion/pull/15544#discussion_r2065191063
##########
datafusion/functions-aggregate/src/array_agg.rs:
##########
@@ -288,10 +300,23 @@ impl Accumulator for ArrayAggAccumulator {
return internal_err!("expects single batch");
}
- let val = Arc::clone(&values[0]);
+ let val = &values[0];
+ let nulls = if self.ignore_nulls {
+ val.logical_nulls()
+ } else {
+ None
+ };
+
+ let val = match nulls {
+ Some(nulls) if nulls.null_count() >= val.len() => return Ok(()),
Review Comment:
how could the null count be greater than the length? or is the `>=` a
defensive coding mechanism?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
