goldmedal commented on PR #15748: URL: https://github.com/apache/datafusion/pull/15748#issuecomment-2838641022
> I think the groups accumulator will result in faster performance, not new functionality. Thanks for the explanation. If it's a performance improvement, it's better to run some benchmark or add the benchmark case in `datafusion/functions-aggregate/benches` to prove the result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
