iffyio commented on code in PR #1828:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1828#discussion_r2067148582
##########
src/ast/mod.rs:
##########
@@ -3319,6 +3319,18 @@ pub enum Statement {
drop_behavior: Option<DropBehavior>,
},
/// ```sql
+ /// DROP DOMAIN
+ /// ```
+ /// See
[PostgreSQL](https://www.postgresql.org/docs/current/sql-dropdomain.html)
+ ///
+ /// DROP DOMAIN [ IF EXISTS ] name [, ...] [ CASCADE | RESTRICT ]
+ ///
+ DropDomain {
+ if_exists: bool,
+ name: ObjectName,
+ drop_behavior: Option<DropBehavior>,
+ },
Review Comment:
Could we wrap the new statement in a named struct? We're looking to move
over to [that
pattern](https://github.com/apache/datafusion-sqlparser-rs/issues/1204) for
newer statements. e.g.
```rust
struct DropDomain {
if_exist: bool
// ...
}
Statement::DropDomain(DropDomain)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
