hsiang-c commented on code in PR #1696: URL: https://github.com/apache/datafusion-comet/pull/1696#discussion_r2067407711
########## docs/source/user-guide/datasources.md: ########## @@ -19,29 +19,36 @@ # Supported Spark Data Sources -## Parquet +## File Formats + +### Parquet When `spark.comet.scan.enabled` is enabled, Parquet scans will be performed natively by Comet if all data types in the schema are supported. When this option is not enabled, the scan will fall back to Spark. In this case, enabling `spark.comet.convert.parquet.enabled` will immediately convert the data into Arrow format, allowing native execution to happen after that, but the process may not be efficient. -## CSV +### CSV Comet does not provide native CSV scan, but when `spark.comet.convert.csv.enabled` is enabled, data is immediately converted into Arrow format, allowing native execution to happen after that. -## JSON +### JSON Comet does not provide native JSON scan, but when `spark.comet.convert.json.enabled` is enabled, data is immediately converted into Arrow format, allowing native execution to happen after that. -# Supported Storages +## Data Catalogs + +### Apache Iceberg + +See the dedicated [Comet and Iceberg Guide](iceberg.md). + +## Supported Storages -## Local Review Comment: (nit) Should we keep `###Local`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
