gabotechs commented on issue #15069: URL: https://github.com/apache/datafusion/issues/15069#issuecomment-2841521737
> another potential issue is that it would effectively "tax" other features in the sense that writing tests for unrelated features might trigger a substrait bug that was unrelated to the test being written Fortunately [sqllogictest-rs](https://github.com/risinglightdb/sqllogictest-rs) has support for this via engine names. Having a separate implementation of sqllogictest::AsyncDB with a "DataFusionSubstraitRoundrip" engine name should allow us to flag individual sqllogictests with `skipif DataFusionSubstraitRoundrip`. Although I imagine that if we go down this path, some time will pass until this new testing mode can be enabled in the CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
