MohamedAbdeen21 opened a new pull request, #1835: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1835
The dialects that support underscore as a separator in numeric literals used to parse `._123` as a number, which is fine. But that means that something like `._abc` would be parsed as Number `._` and word `abc`, which is wrong. This PR splits the tokenizer match branch for numbers and periods into two branches to make things easier, fixes the issue mentioned above, and adds tests. CC: @mvzink -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org