aharpervc commented on code in PR #1834:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1834#discussion_r2070278308
##########
src/ast/mod.rs:
##########
@@ -3744,7 +3750,7 @@ pub enum Statement {
or_alter: bool,
name: ObjectName,
params: Option<Vec<ProcedureParam>>,
- body: Vec<Statement>,
+ body: BeginEndStatements,
Review Comment:
It it an abuse of BeginEndStatements to potentially have the begin/end token
be empty? This could alternately be an enum of BeginEndStatements and Sequence,
similar to elsewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
