mbutrovich commented on code in PR #1700:
URL: https://github.com/apache/datafusion-comet/pull/1700#discussion_r2070460938
##########
spark/src/test/scala/org/apache/comet/CometFuzzTestSuite.scala:
##########
@@ -188,6 +188,22 @@ class CometFuzzTestSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("regexp_replace") {
+ withSQLConf(CometConf.COMET_REGEXP_ALLOW_INCOMPATIBLE.key -> "true") {
+ val df = spark.read.parquet(filename)
+ df.createOrReplaceTempView("t1")
+ // We want to make sure that the schema generator wasn't modified to
accidentally omit
+ // StringType, since then this test would not run any queries and
silently pass.
+ var testedString = false
+ for (field <- df.schema.fields if field.dataType == StringType) {
+ testedString = true
+ val sql = s"SELECT regexp_replace(${field.name}, 'a', 'b') FROM t1"
Review Comment:
Makes sense. I find myself expanding the generator for #1697 to create
dictionaries, so let me sync up with you for good solutions to expand the
schemas and values in specific types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
