Copilot commented on code in PR #15921:
URL: https://github.com/apache/datafusion/pull/15921#discussion_r2071745291
##########
datafusion/spark/src/function/utils.rs:
##########
@@ -28,7 +28,7 @@ pub mod test {
let expected: datafusion_common::Result<Option<$EXPECTED_TYPE>> =
$EXPECTED;
let func = $FUNC;
- let arg_fields_owned = $ARGS
+ let arg_fields_owned: Vec<arrow::datatypes::Field> = $ARGS
Review Comment:
[nitpick] If $ARGS already yields a Vec<arrow::datatypes::Field>, the
explicit type annotation might be redundant. Consider removing it or adding a
comment to clarify its purpose.
```suggestion
let arg_fields_owned = $ARGS
```
##########
datafusion/spark/src/function/utils.rs:
##########
@@ -42,6 +42,8 @@ pub mod test {
})
.collect::<Vec<_>>();
+ let arg_fields: Vec<&arrow::datatypes::Field> =
arg_fields_owned.iter().collect();
+
Review Comment:
[nitpick] An extra blank line appears after constructing 'arg_fields'; if it
does not serve an intentional grouping purpose, consider removing it to
maintain consistent formatting.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
