jonathanc-n commented on code in PR #15862:
URL: https://github.com/apache/datafusion/pull/15862#discussion_r2071905742
##########
datafusion/expr/src/logical_plan/dml.rs:
##########
@@ -241,3 +241,10 @@ fn make_count_schema() -> DFSchemaRef {
.unwrap(),
)
}
+
Review Comment:
Yes, I didn't fully complete the pull request yet. Currently, the
implementation is converting the table factors into a scan that are then
combined into a join; the extra flag columns are used to perform matching
later on when branching for the INSERTs, UPDATEs, and DELETEs. Do you think
just passing along a Scan instead of fully converting into a join would be
better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
