alamb commented on code in PR #15919:
URL: https://github.com/apache/datafusion/pull/15919#discussion_r2072147661
##########
datafusion-cli/src/main.rs:
##########
@@ -177,13 +177,14 @@ async fn main_inner() -> Result<()> {
// set disk limit
if let Some(disk_limit) = args.disk_limit {
- let disk_manager = DiskManager::try_new(DiskManagerConfig::NewOs)?;
+ let mut disk_manager = DiskManager::try_new(DiskManagerConfig::NewOs)?;
Review Comment:
What would be nicer would be if try_new didn't return an Arc -- but that is
a more disruptive change so I think this solution improves things even if it is
non ideal
##########
datafusion/execution/src/disk_manager.rs:
##########
@@ -120,10 +120,10 @@ impl DiskManager {
}
}
- pub fn with_max_temp_directory_size(
- mut self,
+ pub fn set_max_temp_directory_size(
Review Comment:
perhaps can we add some comments / example to these functions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
