andygrove commented on code in PR #1711:
URL: https://github.com/apache/datafusion-comet/pull/1711#discussion_r2072234181
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -1139,6 +1139,26 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ // TODO: test currently fails with
+ // Unsupported Data Type: Spark `expm1` function expects Float64, got Utf8
+ test("expm1") {
+ // TODO test with null inputs
+ val testValues = Seq(
+ -1,
+ 0,
+ +1,
+ Double.MinValue,
+ Double.MaxValue,
+ Double.NaN,
+ Double.MinPositiveValue,
+ Double.PositiveInfinity,
+ Double.NegativeInfinity)
+ val testValuesRepeated = testValues.flatMap(v => Seq.fill(1000)(v))
+ withParquetTable(testValuesRepeated.map(n => (n, n)), "tbl") {
+ checkSparkAnswerWithTol("SELECT expm1(_1) FROM tbl")
Review Comment:
This test fails with `Unsupported Data Type: Spark `expm1` function expects
Float64, got Utf8`, but if I change the test to call `tan` instead of `expm1`,
then it passes. I do not understand where `Utf8` is coming from yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
