2010YOUY01 commented on code in PR #15905:
URL: https://github.com/apache/datafusion/pull/15905#discussion_r2072352105
##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -234,15 +235,45 @@ async fn run_test_file(
runner.with_column_validator(strict_column_validator);
runner.with_normalizer(value_normalizer);
runner.with_validator(validator);
+ let result = run_file_in_runner(path, runner).await;
+ pb.finish_and_clear();
+ result
+}
- let res = runner
- .run_file_async(path)
- .await
- .map_err(|e| DataFusionError::External(Box::new(e)));
+async fn run_file_in_runner<D: AsyncDB, M: MakeConnection<Conn = D>>(
Review Comment:
```suggestion
/// Run the test file specified by `path` using the provided runner.
/// Only first `ERRS_PER_FILE_LIMIT` errors will be displayed.
async fn run_file_in_runner<D: AsyncDB, M: MakeConnection<Conn = D>>(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
