Rachelint commented on PR #15591:
URL: https://github.com/apache/datafusion/pull/15591#issuecomment-2848551270
> > 🤖: Benchmark completed
>
> (I am surprised this PR didn't yield better results, I am reruning now to
see if the results are reproducable
I am back from holiday, and continue to work on this today.
Because for simplicity for the initial pr, I just:
- Implement the blocked version `GroupValuesPrimitive` for `GroupValues`
- and `PrimitiveGroupsAccumulator` for `GroupAccumulator`
And actually still don't have such a simple query can show the improvement
now...
And for showing the improvement, I add an new query in
`clickbench/extended.sql`:
```sql
SELECT "WatchID", MIN("ResolutionWidth"), MAX("ResolutionWidth"),
SUM("IsRefresh") FROM hits GROUP BY "WatchID" ORDER BY "WatchID" DESC LIMIT 10;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
