qstommyshu commented on code in PR #15937:
URL: https://github.com/apache/datafusion/pull/15937#discussion_r2072659106
##########
datafusion/optimizer/src/propagate_empty_relation.rs:
##########
@@ -280,8 +291,7 @@ mod tests {
.project(vec![binary_expr(lit(1), Operator::Plus, lit(1))])?
.build()?;
- let expected = "EmptyRelation";
- assert_eq(plan, expected)
+ assert_optimized_plan_equal!(plan, @"EmptyRelation")
Review Comment:
It was testing optimized plan, the original function here is `assert_eq` not
`assert_eq!` (the name is confusing, see the change in line 254, 255). The
original implementation of `fn assert_eq` calls `assert_optimized_plan_eq`
internally, so it is still testing optimized plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
