nuno-faria opened a new pull request, #1123:
URL: https://github.com/apache/datafusion-python/pull/1123
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
N/A.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Supporting all Parquet writer options allows us more flexibility when
creating data directly from `datafusion-python`.
For consistency, it supports all writer options defined by `ParquetOptions`
in `datafusion`, using the same defaults:
https://github.com/apache/datafusion/blob/555fc2e24dd669e44ac23a9a1d8406f4ac58a9ed/datafusion/common/src/config.rs#L423.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Extended `write_parquet` with all writer options, including
column-specific options.
- Added relevant tests. (Since `pyarrow` does not expose page-level
information, some options could not be directly tested, like enabling
bloom-filters (an external tool confirmed that this option works). For this
specific case, in this a test compares the file sizes, given bloom-filters
increase the storage required.)
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
The main difference relates to the existing `compression` field, which now
uses a `str` like `datafusion`, instead of a custom enum. The main advantage is
that future algorithms will not require updating the Python-side code.
Additionally, the default compression was changed from `zstd(4)` to
`zstd(3)`, the same as `datafusion`.
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
