alamb commented on code in PR #15857:
URL: https://github.com/apache/datafusion/pull/15857#discussion_r2075261355
##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -726,6 +726,8 @@ fn extract_window_frame_target_type(col_type: &DataType) ->
Result<DataType> {
Ok(DataType::Interval(IntervalUnit::MonthDayNano))
} else if let DataType::Dictionary(_, value_type) = col_type {
extract_window_frame_target_type(value_type)
+ } else if let DataType::List(field) = col_type {
+ extract_window_frame_target_type(field.data_type())
Review Comment:
It seems to be related to converting window frames when they have `RANGE`
rather than `ROWS` -- so maybe we need some more tests. I'll comment below
https://github.com/apache/datafusion/blob/86db4bf3c5af9704377afa1ecc596ce7d9167f7f/datafusion/optimizer/src/analyzer/type_coercion.rs#L749-L748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
