goldmedal opened a new pull request, #15965:
URL: https://github.com/apache/datafusion/pull/15965
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
Previously, we showed the physical type name for the function parameter
type. However, it produces too many similar records for a function. For
example, if we try to get the parameters of `string_agg`, we will get the
result:
```
datafusion public string_agg 1 IN expression LargeUtf8 NULL false 0
datafusion public string_agg 2 IN delimiter Utf8 NULL false 0
datafusion public string_agg 1 OUT NULL LargeUtf8 NULL false 0
datafusion public string_agg 1 IN expression LargeUtf8 NULL false 1
datafusion public string_agg 2 IN delimiter LargeUtf8 NULL false 1
datafusion public string_agg 1 OUT NULL LargeUtf8 NULL false 1
datafusion public string_agg 1 IN expression LargeUtf8 NULL false 2
datafusion public string_agg 2 IN delimiter Null NULL false 2
datafusion public string_agg 1 OUT NULL LargeUtf8 NULL false 2
datafusion public string_agg 1 IN expression Utf8 NULL false 3
datafusion public string_agg 2 IN delimiter Utf8 NULL false 3
datafusion public string_agg 1 OUT NULL LargeUtf8 NULL false 3
datafusion public string_agg 1 IN expression Utf8 NULL false 4
datafusion public string_agg 2 IN delimiter LargeUtf8 NULL false 4
datafusion public string_agg 1 OUT NULL LargeUtf8 NULL false 4
datafusion public string_agg 1 IN expression Utf8 NULL false 5
datafusion public string_agg 2 IN delimiter Null NULL false 5
datafusion public string_agg 1 OUT NULL LargeUtf8 NULL false 5
```
`LargeUtf8` and `Utf8` can be represented by `NativeType::String`. So, after
we change to the logical type name, we can get
```
datafusion public string_agg 2 IN delimiter Null NULL false 0
datafusion public string_agg 1 IN expression String NULL false 0
datafusion public string_agg 1 OUT NULL String NULL false 0
datafusion public string_agg 1 IN expression String NULL false 1
datafusion public string_agg 2 IN delimiter String NULL false 1
datafusion public string_agg 1 OUT NULL String NULL false 1
```
The number of combinations can be decreased significantly.
I think that it's enough to make the user know how to use the function
through the logical type name.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
- Show native type for the column of `INFORMATION_SCHEMA.parameters` and
`routines`.
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
sqllogictests
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
Now, users get the logical type name instead of the physical type name.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
