thinkharderdev commented on code in PR #15968:
URL: https://github.com/apache/datafusion/pull/15968#discussion_r2076322499
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/bytes.rs:
##########
@@ -187,6 +194,13 @@ where
{
let value: &[u8] = array.value(row).as_ref();
self.buffer.append_slice(value);
+
+ assert!(
Review Comment:
Yeah I think in general it would be better. Panicking due to offset overflow
is common in other places though so it's not that jarring :)
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/bytes.rs:
##########
@@ -62,6 +64,11 @@ where
buffer: BufferBuilder::new(INITIAL_BUFFER_CAPACITY),
offsets: vec![O::default()],
nulls: MaybeNullBufferBuilder::new(),
+ max_buffer_size: if O::IS_LARGE {
Review Comment:
Agreed: https://github.com/apache/arrow-rs/issues/7474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
