ashdnazg commented on PR #15924: URL: https://github.com/apache/datafusion/pull/15924#issuecomment-2857822728
@alamb @chenkovsky I pushed a version that uses `copy_array_data` to make sure `take` isn't doing anything funny (looking at the code, at the moment it doesn't, but the docs promise nothing). I also replaced the `force_clone()` calls with `compact()`. One could improve the `compact` function in the future to avoid copying if it's unnecessary, but it's difficult to do this correctly (you need to go recursively into all arrays, offsets and buffers), so I decided it's probably not worth the effort at the moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
