kosiew commented on code in PR #15999:
URL: https://github.com/apache/datafusion/pull/15999#discussion_r2080846902
##########
datafusion/ffi/src/plan_properties.rs:
##########
@@ -321,7 +321,7 @@ mod tests {
let foreign_props: PlanProperties = local_props_ptr.try_into()?;
- assert!(format!("{:?}", foreign_props) == format!("{:?}",
original_props));
+ assert!(format!("{foreign_props:?}") == format!("{original_props:?}"));
Review Comment:
good opportunity to improve this to:
```rust
assert_eq!(format!("{foreign_props:?}"),
format!("{original_props:?}"));
```
##########
datafusion-cli/src/catalog.rs:
##########
@@ -351,15 +351,7 @@ mod tests {
);
let input =
"~/Code/datafusion/benchmarks/data/tpch_sf1/part/part-0.parquet";
let expected = format!(
Review Comment:
This is a good opportunity to refactor this to:
```rust
use std::path::PathBuf;
// use std::path::MAIN_SEPARATOR; can be removed
let expected = PathBuf::from(test_home_path)
.join("Code")
.join("datafusion")
.join("benchmarks")
.join("data")
.join("tpch_sf1")
.join("part")
.join("part-0.parquet")
.to_string_lossy()
.to_string();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
