gabotechs commented on code in PR #16025:
URL: https://github.com/apache/datafusion/pull/16025#discussion_r2084928534
##########
datafusion/functions-aggregate/src/min_max.rs:
##########
@@ -625,7 +626,7 @@ fn min_batch(values: &ArrayRef) -> Result<ScalarValue> {
})
}
-fn min_max_batch_struct(array: &ArrayRef, ordering: Ordering) ->
Result<ScalarValue> {
+fn min_max_batch_generic(array: &ArrayRef, ordering: Ordering) ->
Result<ScalarValue> {
Review Comment:
This opens the door to implement Min/Max over any type whose ScalarValue has
an `partial_cmp()` implementation, so really nice that the struct work was
shipped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
