jayzhan211 commented on PR #16031:
URL: https://github.com/apache/datafusion/pull/16031#issuecomment-2876910540
> @jayzhan211 After looking into it, generating the plan programatically may
become very unwieldy (very verbose). Is your concern about the size of the file
checked into git, or the fact that it's hard to read because it's so large? If
it's the former, I can put in two files and put together some string
formatting. If it's the former, this won't help as much, but will still be more
readable for humans.
My idea is that we can generate such parameters for the code we want to
test, we don't need end to end test from json.
I take a quick look, if we enter this function, I think it is possible to
generate a deep nested `Expression` that easily cause stack overflow.
```rust
async fn consume_expression(
&self,
expr: &Expression,
input_schema: &DFSchema,
) -> datafusion::common::Result<Expr> {
from_substrait_rex(self, expr, input_schema).await
}
```
If that doesn't work, I think we don't even need to keep such test since the
change to me is quite trivial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
