timsaucer commented on code in PR #16053: URL: https://github.com/apache/datafusion/pull/16053#discussion_r2094500696
########## datafusion/physical-expr/src/expressions/literal.rs: ########## @@ -34,15 +36,37 @@ use datafusion_expr_common::interval_arithmetic::Interval; use datafusion_expr_common::sort_properties::{ExprProperties, SortProperties}; /// Represents a literal value -#[derive(Debug, PartialEq, Eq, Hash)] +#[derive(Debug, PartialEq, Eq)] pub struct Literal { value: ScalarValue, + metadata: Option<HashMap<String, String>>, Review Comment: Oh, I hadn't thought about that. That's a very interesting way to solve one of the problems I was coming up against. I will try a proof of concept of that on a separate branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org