alamb commented on PR #16016: URL: https://github.com/apache/datafusion/pull/16016#issuecomment-2888987223
Also, I wonder if you have based this implementation on the structure in any existing system (e.g. Calcite or DuckDB)? I think following the DataFusion model of "implement well know good patterns" it would be good to follow an existing structure unless there is a reason to diverge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
