Re: [PR] Implement intermediate result blocked approach to aggregation memory management [datafusion]

Mon, 19 May 2025 03:43:34 -0700 


alamb commented on PR #15591:
URL: https://github.com/apache/datafusion/pull/15591#issuecomment-2890539606

   ๐Ÿค–: Benchmark completed
   
   <details><summary>Details</summary>
   <p>
   
   
   ```
   Comparing HEAD and intermeidate-result-blocked-approach
   --------------------
   Benchmark clickbench_extended.json
   --------------------
   
โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Query        โ”ƒ       HEAD โ”ƒ intermeidate-result-blocked-approach โ”ƒ        
Change โ”ƒ
   
โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ QQuery 0     โ”‚  1916.94ms โ”‚                            1866.52ms โ”‚     no 
change โ”‚
   โ”‚ QQuery 1     โ”‚   709.88ms โ”‚                             673.73ms โ”‚ +1.05x 
faster โ”‚
   โ”‚ QQuery 2     โ”‚  1482.93ms โ”‚                            1391.57ms โ”‚ +1.07x 
faster โ”‚
   โ”‚ QQuery 3     โ”‚   701.88ms โ”‚                             721.01ms โ”‚     no 
change โ”‚
   โ”‚ QQuery 4     โ”‚  1494.91ms โ”‚                            1494.55ms โ”‚     no 
change โ”‚
   โ”‚ QQuery 5     โ”‚ 15627.54ms โ”‚                           15418.84ms โ”‚     no 
change โ”‚
   โ”‚ QQuery 6     โ”‚  2070.08ms โ”‚                            2042.39ms โ”‚     no 
change โ”‚
   โ”‚ QQuery 7     โ”‚  2108.54ms โ”‚                            1952.66ms โ”‚ +1.08x 
faster โ”‚
   
โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Benchmark Summary                                   โ”ƒ            โ”ƒ
   โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ Total Time (HEAD)                                   โ”‚ 26112.69ms โ”‚
   โ”‚ Total Time (intermeidate-result-blocked-approach)   โ”‚ 25561.26ms โ”‚
   โ”‚ Average Time (HEAD)                                 โ”‚  3264.09ms โ”‚
   โ”‚ Average Time (intermeidate-result-blocked-approach) โ”‚  3195.16ms โ”‚
   โ”‚ Queries Faster                                      โ”‚          3 โ”‚
   โ”‚ Queries Slower                                      โ”‚          0 โ”‚
   โ”‚ Queries with No Change                              โ”‚          5 โ”‚
   โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   ```
   
   
   </p>
   </details>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to