jfahne commented on code in PR #16082:
URL: https://github.com/apache/datafusion/pull/16082#discussion_r2095841116
##########
datafusion/core/src/dataframe/mod.rs:
##########
@@ -977,7 +977,7 @@ impl DataFrame {
.filter(|f| {
!matches!(f.data_type(), DataType::Binary |
DataType::Boolean)
})
- .map(|f| min(col(f.name())).alias(f.name()))
+ .map(|f| min(col(format!("\"{}\"",
f.name()))).alias(f.name()))
Review Comment:
updated the main PR comment with a lot of context. main point:
> My concern in using ident to potentially more readily handle messier
column names is that by doing no parsing it may break describe on something
like a Postgres table.
I think it boils down to `column_by_name` works when called on `RecordBatch`
with the `ident` function. I'll look into it unless someone can confirm that it
would be safe/unsafe to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
