adriangb commented on code in PR #16086:
URL: https://github.com/apache/datafusion/pull/16086#discussion_r2095854477
##########
datafusion/core/src/datasource/physical_plan/parquet.rs:
##########
@@ -156,10 +162,20 @@ mod tests {
source = source
.with_pushdown_filters(true)
.with_reorder_filters(true);
+ } else {
+ source = source.with_pushdown_filters(false);
}
Review Comment:
This is just to be explicit
##########
datafusion/core/src/datasource/physical_plan/parquet.rs:
##########
@@ -156,10 +162,20 @@ mod tests {
source = source
.with_pushdown_filters(true)
.with_reorder_filters(true);
+ } else {
+ source = source.with_pushdown_filters(false);
}
if self.page_index_predicate {
source = source.with_enable_page_index(true);
+ } else {
+ source = source.with_enable_page_index(false);
+ }
+
+ if self.bloom_filters {
+ source = source.with_bloom_filter_on_read(true);
+ } else {
+ source = source.with_bloom_filter_on_read(false);
}
Review Comment:
Otherwise bloom filters will pick up the slack and do pruning even if the
types mismatch and stats / page / row pruning fails (bloom filters use &str for
both Utf8 and Utf8View so they don't care).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
