alamb commented on code in PR #1705:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1705#discussion_r2096154003
##########
src/tokenizer.rs:
##########
@@ -1229,14 +1229,26 @@ impl<'a> Tokenizer<'a> {
// operators
'-' => {
chars.next(); // consume the '-'
+
match chars.peek() {
Some('-') => {
- chars.next(); // consume the second '-', starting
a single-line comment
- let comment =
self.tokenize_single_line_comment(chars);
-
Ok(Some(Token::Whitespace(Whitespace::SingleLineComment {
- prefix: "--".to_owned(),
- comment,
- })))
+ let mut is_comment = true;
+ if
self.dialect.requires_single_line_comment_whitespace() {
+ is_comment = Some(' ') ==
chars.peekable.clone().nth(1);
Review Comment:
A follow on PR would be most appreciated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
