Dandandan commented on code in PR #16087:
URL: https://github.com/apache/datafusion/pull/16087#discussion_r2096168025
##########
datafusion/functions/src/string/ascii.rs:
##########
@@ -103,19 +103,22 @@ impl ScalarUDFImpl for AsciiFunc {
fn calculate_ascii<'a, V>(array: V) -> Result<ArrayRef, ArrowError>
where
- V: ArrayAccessor<Item = &'a str>,
+ V: StringArrayType<'a, Item = &'a str>,
{
- let iter = ArrayIter::new(array);
- let result = iter
- .map(|string| {
- string.map(|s| {
- let mut chars = s.chars();
- chars.next().map_or(0, |v| v as i32)
- })
+ let values: Vec<_> = (0..array.len())
+ .map(|i| {
+ if array.is_null(i) {
+ 0
Review Comment:
I realize now the spec doesn't say anything about the offset pointing to
valid utf8 or not.
But `value(i)` being not unsafe, I guess `arrow-rs` should provide that
guarantee.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
