alamb commented on code in PR #16109:
URL: https://github.com/apache/datafusion/pull/16109#discussion_r2097692753
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -206,8 +201,6 @@ struct ExternalSorter {
schema: SchemaRef,
/// Sort expressions
expr: Arc<[PhysicalSortExpr]>,
- /// RowConverter corresponding to the sort expressions
- sort_keys_row_converter: Arc<RowConverter>,
Review Comment:
this was only used for multi-column sorts when one of the columns was
`List`. This feature was added to arrow-rs in
- https://github.com/apache/arrow-rs/issues/5454
- https://github.com/apache/arrow-rs/pull/5455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
