xudong963 commented on code in PR #16133:
URL: https://github.com/apache/datafusion/pull/16133#discussion_r2102030020
##########
datafusion/core/src/datasource/physical_plan/parquet.rs:
##########
@@ -867,18 +904,25 @@ mod tests {
#[tokio::test]
async fn evolved_schema_column_type_filter_strings() {
// The table and filter have a common data type, but the file schema
differs
- let c1: ArrayRef =
- Arc::new(StringViewArray::from(vec![Some("foo"), Some("bar")]));
- let batch = create_batch(vec![("c1", c1.clone())]);
+ let table_schema = Arc::new(Schema::new(vec![Field::new(
+ "c1",
+ DataType::Utf8View,
+ false,
+ )]));
- let schema = Arc::new(Schema::new(vec![Field::new("c1",
DataType::Utf8, false)]));
+ let file_schema =
+ Arc::new(Schema::new(vec![Field::new("c1", DataType::Utf8,
false)]));
+ let file_c1: ArrayRef =
+ Arc::new(StringArray::from(vec![Some("foo"), Some("bar")]));
+ let file_batch = create_batch(vec![("c1", file_c1.clone())]);
// Predicate should prune all row groups
- let filter =
col("c1").eq(lit(ScalarValue::Utf8(Some("aaa".to_string()))));
+ let filter =
col("c1").eq(lit(ScalarValue::Utf8View(Some("aaa".to_string()))));
Review Comment:
Use `Utf8View` to align with `table_schema`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
